On 8/2/19 10:22 AM, Roger Pau Monne wrote: > Switch rmrr_identity_mapping to use iommu_{un}map in order to > establish RMRR mappings for PV domains, like it's done in > arch_iommu_hwdom_init. This solves the issue of a PV hardware domain > not getting RMRR mappings because {set/clear}_identity_p2m_entry was > not properly updating the iommu page tables.
Sorry, I think this description is somewhat backwards: you're saying what you're doing first, and then saying what the problematic behavior was, but not actually saying what was causing the problematic behavior. Why was {set,clear}_identity_p2m not updating the page tables? I agree with Jan, that figuring that out is a prerequisite for any kind of fix: if `need_iommu_pt_sync()` is false at that point for the hardware domain, then there's a bigger problem than RMRRs not being adjusted properly. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel