On 12/08/2019 08:23, Jan Beulich wrote: > @@ -747,16 +747,10 @@ void load_system_tables(void) > .bitmap = IOBMP_INVALID_OFFSET, > }; > > - _set_tssldt_desc( > - gdt + TSS_ENTRY, > - (unsigned long)tss, > - offsetof(struct tss_struct, __cacheline_filler) - 1, > - SYS_DESC_tss_avail); > - _set_tssldt_desc( > - compat_gdt + TSS_ENTRY, > - (unsigned long)tss, > - offsetof(struct tss_struct, __cacheline_filler) - 1, > - SYS_DESC_tss_busy); > + _set_tssldt_desc(gdt + TSS_ENTRY, (unsigned long)tss, > + sizeof(*tss) - 1, SYS_DESC_tss_avail); > + _set_tssldt_desc(compat_gdt + TSS_ENTRY, (unsigned long)tss, > + sizeof(*tss) - 1, SYS_DESC_tss_busy);
Do you think it is worth having a BUILD_BUG_ON(sizeof(*tss) < 0x67), just to confirm that the load wont fault? Everything else LGTM. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
