On 01/08/2019 14:33, Volodymyr Babchuk wrote:
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 4c8404155a..bc7d17dd2c 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -621,17 +621,20 @@ static void __init set_interrupt(gic_interrupt_t
>> interrupt,
>> * "interrupts": contains the list of interrupts
>> * "interrupt-parent": link to the GIC
>> */
>> -static int __init fdt_property_interrupts(void *fdt, gic_interrupt_t *intr,
>> +static int __init fdt_property_interrupts(const struct kernel_info *kinfo,
>> + gic_interrupt_t *intr,
>> unsigned num_irq)
>> {
>> int res;
>> + uint32_t phandle = is_hardware_domain(kinfo->d) ?
>> + dt_interrupt_controller->phandle : GUEST_PHANDLE_GIC;
>>
>> - res = fdt_property(fdt, "interrupts", intr, sizeof (intr[0]) * num_irq);
>> + res = fdt_property(kinfo->fdt, "interrupts",
>> + intr, sizeof (intr[0]) * num_irq);
Just as a minor style point seeing as these are in discussion at the
moment. sizeof() is written without a space, as if it was a function
not an operator.
This can easily be fixed on commit.
Everything else I can spot looks fine.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
