> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: 30 July 2019 13:03
> To: Paul Durrant <paul.durr...@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
> <andrew.coop...@citrix.com>; Roger Pau Monne
> <roger....@citrix.com>; Wei Liu <w...@xen.org>
> Subject: Re: [Xen-devel] [PATCH v3 5/5] x86/domain: remove the 's3_integrity'
> flag
>
> On 30.07.2019 11:39, Paul Durrant wrote:
> > --- a/xen/arch/x86/domain.c
> > +++ b/xen/arch/x86/domain.c
> > @@ -466,6 +466,13 @@ int arch_sanitise_domain_config(struct
> > xen_domctl_createdomain *config)
> > return -EINVAL;
> > }
> >
> > + if ( (config->flags & XEN_DOMCTL_CDF_s3_integrity) &&
> > + !IS_ENABLED(TBOOT) )
>
> This lacks the CONFIG_ prefix.
>
> > --- a/xen/arch/x86/setup.c
> > +++ b/xen/arch/x86/setup.c
> > @@ -689,7 +689,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> > .stop_bits = 1
> > };
> > struct xen_domctl_createdomain dom0_cfg = {
> > - .flags = XEN_DOMCTL_CDF_s3_integrity,
> > + .flags = IS_ENABLED(TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0,
>
> Same here. With this taken care of (could be done while committing,
> but I'm not sure whether this patch is independent of the earlier
> ones)
> Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks. I'll fix it in v4.
Paul
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
