On 29.07.2019 14:11, Andrew Cooper wrote: > The buggy version of GCC isn't supported by Xen, so reimplement the helpers > with type checking, using Xen's latest type expectations. > > Signed-off-by: Andrew Cooper <[email protected]>
Acked-by: Jan Beulich <[email protected]> with one remark: > @@ -117,9 +108,10 @@ static inline void cpumask_clear(cpumask_t *dstp) > bitmap_zero(dstp->bits, nr_cpumask_bits); > } > > -/* No static inline type checking - see Subtlety (1) above. */ > -#define cpumask_test_cpu(cpu, cpumask) \ > - test_bit(cpumask_check(cpu), (cpumask)->bits) > +static inline bool cpumask_test_cpu(unsigned int cpu, const cpumask_t *dst) In particular in combination with const I don't think "dst" is a particularly good name. "src", "msk", or "mask" would all seem better to me. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
