On 29.07.2019 19:38, Andrew Cooper wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -108,6 +108,12 @@ idt_entry_t __section(".bss.page_aligned") > __aligned(PAGE_SIZE) > /* Pointer to the IDT of every CPU. */ > idt_entry_t *idt_tables[NR_CPUS] __read_mostly; > > +/* > + * The TSS is smaller than a page, but we give it a full page to avoid > + * adjacent per-cpu data leaking via Meltdown when XPTI is in use. > + */ > +DEFINE_PER_CPU_PAGE_ALIGNED(struct tss_struct, init_tss);
I assume there's a reason why you didn't introduce a wrapper union to pad this to page size - I'd like to understand this reason (see also my reply to patch 1) before acking both patches. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel