On Fri, Jul 19, 2019 at 11:37 AM Julien Grall <julien.gr...@arm.com> wrote:
>
> Hi Tamas,
>
> On 18/07/2019 18:22, Tamas K Lengyel wrote:
> >> - Line 139: The { are commonly on the same line as struct or
> >> definition.
> >
> > According to CODING_STYLE that's not how it should be.
>
> I guess you refer to the section "Bracing". If so, I think we don't follow the
> CODING_STYLE for struct or definition.
>
> I have to admit that for this case, I always have to look at other usage in
> the
> code because I tend to put the { on a newline.
>
> I was going to say that there may be some cases where it makes sense to keep {
> on the same line. For instance:
>
> { a, b, c, d },
> { e, f, g, h },
>
All the rules should be stated in CODING_STYLE explicitly.
In other cases, it cannot be automated with future proves why it works
this or that way.
Thanks
> But it looks like astyle is allowing it (see line 24759).
>
> Cheers,
>
> --
> Julien Grall
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
