> -----Original Message-----
> From: Roger Pau Monne <roger....@citrix.com>
> Sent: 25 July 2019 10:48
> To: Paul Durrant <paul.durr...@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Stefano Stabellini
> <sstabell...@kernel.org>; Wei Liu <w...@xen.org>;
> Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; George Dunlap
> <george.dun...@citrix.com>; Andrew
> Cooper <andrew.coop...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Tim
> (Xen.org) <t...@xen.org>;
> Julien Grall <julien.gr...@arm.com>; Jan Beulich <jbeul...@suse.com>; Daniel
> De Graaf
> <dgde...@tycho.nsa.gov>
> Subject: Re: [Xen-devel] [PATCH 5/6] domain: remove the 'is_xenstore' flag
>
> On Tue, Jul 23, 2019 at 05:06:08PM +0100, Paul Durrant wrote:
> > This patch introduces a convenience macro, is_xenstore_domain(), which
> > tests the domain 'createflags' directly and then uses that in place of
> > the 'is_xenstore' flag.
> >
> > Signed-off-by: Paul Durrant <paul.durr...@citrix.com>
>
> Reviewed-by: Roger Pau Monné <roger....@citrix.com>
>
Thanks.
> Just one request below (which is not related to your code actually).
>
> > ---
> > Cc: Andrew Cooper <andrew.coop...@citrix.com>
> > Cc: George Dunlap <george.dun...@eu.citrix.com>
> > Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> > Cc: Jan Beulich <jbeul...@suse.com>
> > Cc: Julien Grall <julien.gr...@arm.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
> > Cc: Stefano Stabellini <sstabell...@kernel.org>
> > Cc: Tim Deegan <t...@xen.org>
> > Cc: Wei Liu <w...@xen.org>
> > Cc: Daniel De Graaf <dgde...@tycho.nsa.gov>
> > ---
> > xen/common/domain.c | 5 +----
> > xen/common/domctl.c | 2 +-
> > xen/include/xen/sched.h | 7 +++++--
> > xen/include/xsm/dummy.h | 2 +-
> > 4 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/xen/common/domain.c b/xen/common/domain.c
> > index 6f405d2541..5703da357f 100644
> > --- a/xen/common/domain.c
> > +++ b/xen/common/domain.c
> > @@ -429,11 +429,8 @@ struct domain *domain_create(domid_t domid,
> > watchdog_domain_init(d);
> > init_status |= INIT_watchdog;
> >
> > - if ( d->createflags & XEN_DOMCTL_CDF_xs_domain )
> > - {
> > - d->is_xenstore = 1;
> > + if ( is_xenstore_domain(d) )
> > d->disable_migrate = 1;
>
> While here can you also fix this line to use true instead of 1?
>
Sure.
Paul
> Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
