On 19.07.2019 18:23, Andrew Cooper wrote: > On 16/07/2019 17:35, Jan Beulich wrote: >> This also takes care of several of the shift values wrongly having been >> specified as hex rather than dec. >> >> Take the opportunity and >> - replace a readl() pair by a single readq(), >> - add further fields. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > CI is happy this time around. > > https://gitlab.com/xen-project/people/andyhhp/xen/pipelines/71942193
Hurray. > Acked-by: Andrew Cooper <andrew.coop...@citrix.com> Thanks. > but as a warning, I'm still certain that FEAT() is a fragile, and will > be liable to break on future compilers, seeing as that seem to be the > trend for diagnostics. There's a certain risk, yes. > I'm also unsure whether it works correctly on signed fields. I'm sure it wouldn't, but I don't see any signed fields appearing there. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
