On 27/06/2019 16:20, Jan Beulich wrote: > Also introduce a field in struct amd_iommu caching the most recently > written control register. All writes should now happen exclusively from > that cached value, such that it is guaranteed to be up to date. > > Take the opportunity and add further fields. Also convert a few boolean > function parameters to bool, such that use of !! can be avoided. > > Because of there now being definitions beyond bit 31, writel() also gets > replaced by writeq() when updating hardware. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > --- > v2: Add domain_id_pne field. Mention writel() -> writeq() change.
Acked-by: Andrew Cooper <andrew.coop...@citrix.com>, subject to the resolution of similarities with the previous patch. I'm still concerned that not using bool bitfields is a recipe for a subtle mistakes. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel