On 27/06/2019 07:39, Jan Beulich wrote:
>>>> On 26.06.19 at 19:36, <andrew.coop...@citrix.com> wrote:
>> Clang observes:
>>
>> tools/kconfig/conf.c:77:10:
>> warning: format string is not a string literal (potentially insecure)
>> [-Wformat-security]
>> printf(_("aborted!\n\n"));
>> ^~~~~~~~~~~~~~~~~
>>
>> And it is absolutely correct. gettext() can easily return a string with a %
>> in.
> I'm pretty curious: Where would a % come from when there's none
> in the original English string? I wouldn't call it "proper translation" if
> a translated string had non-textual things in it that the original didn't
> have. Or are there languages using % in ordinary words?
Well - thats why I carefully worded it as "easy to return", rather than
"there are valid translations which contain..."
That said, I bet you can have a lot of fun with translations which use
non-ASCII characters.
> Note that this is in no way an objection to the change, the more
> that it's a reduction of source size.
In which case can I further recommend that we drop the QT and glade
versions. They don't build (and never have it seems).
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
