Hi Stefano,
On 26/06/2019 02:01, Stefano Stabellini wrote:
On Mon, 10 Jun 2019, Julien Grall wrote:
Adjust the coding style used in the comments within cpu_init(). Take the
opportunity to alter the early print to match the function name.
Lastly, document the behavior and the main registers usage within the
function.
Signed-off-by: Julien Grall <julien.gr...@arm.com>
---
xen/arch/arm/arm64/head.S | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 6aa3148192..ee0024173e 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -396,19 +396,26 @@ skip_bss:
ret
ENDPROC(zero_bss)
+/*
+ * Initialize the processor for turning the MMU on.
+ *
+ * Clobbers x0 - x4
Shouldn't it be x0 - x3?
Yes it should be. I will update the comment.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
