On Wed, Jun 05, 2019 at 04:56:01PM +0200, Roger Pau Monné wrote: >On Mon, May 27, 2019 at 04:31:31PM +0800, Chao Gao wrote: >> From: Sergey Dyasli <sergey.dya...@citrix.com> >> >> Currently cpu_sig struct is not updated during boot when either: >> >> 1. ucode_scan is set to false (e.g. no "ucode=scan" in cmdline) >> 2. initrd does not contain a microcode blob >> >> These will result in cpu_sig.rev being 0 which affects APIC's >> check_deadline_errata() and retpoline_safe() functions. >> >> Fix this by getting ucode revision early during boot and SMP bring up. >> While at it. > >I don't understand the last "While at it" sentence. Can it be >removed?
Yes. > >Is this an issue with current code? If so this could be merged ahead of >the rest of the series, and should likely be patch 1. > >OTOH if the issue this patch is fixing is introduced by this series >please merge the fix with the respective patch that introduced the >bug. It is the former. Will send it separately. Really appreciate your other comments. Thanks Chao _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
