> >> + return false; >> + >> + rc = hvmemul_linear_to_phys(gla, &gpa, bytes, &reps, pfec, &ctxt); > > As said before - I don't think it's a good idea to do the page walk > twice: This and the pre-existing one can easily return different > results.
What preexisting page walk are you talking about here? I don't think there is a way to get the gpa by passing it from somewhere. Alex > > Additionally, as also said before (I think), the function may raise > #PF, which you don't seem to deal with despite discarding the > X86EMUL_EXCEPTION return value ... > >> + if ( rc != X86EMUL_OKAY ) >> + return false; > > ... here. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
