On 29/05/2019 05:23, Andrew Cooper wrote: > Drop introduced trailing whitespace, excessively long lines, mal-indention, > superfluous use of PRI macros for int-or-smaller types, and incorrect PRI > macros for gfns and mfns. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: George Dunlap <george.dun...@eu.citrix.com> > CC: Tamas K Lengyel <ta...@tklengyel.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <w...@xen.org> > CC: Roger Pau Monné <roger....@citrix.com>
And can I take this opportunity to remind all committers that `git diff --check` exists and to please make sure it is used as part of pre-push checks. When used against c.s 9abcac7ff, it identifies: andrew@andrew-laptop:~/xen.git/xen$ git diff --check 9abcac7ff^ xen/arch/x86/hvm/hvm.c:1768: trailing whitespace. + /* xen/arch/x86/mm/p2m.c:2443: trailing whitespace. + xen/arch/x86/mm/p2m.c:2481: trailing whitespace. + andrew@andrew-laptop:~/xen.git/xen$ echo $? 2 (and also spots the introduction of conflict markers, although there appear to be no incidents of this mistake in Xen's history.) ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
