>>> On 28.05.19 at 12:33, <jgr...@suse.com> wrote: > @@ -61,6 +62,23 @@ unsigned int sched_granularity = 1; > bool sched_disable_smt_switching; > cpumask_var_t sched_res_mask; > > +#ifdef CONFIG_X86 > +static int __init sched_select_granularity(const char *str) > +{ > + if (strcmp("cpu", str) == 0) > + opt_sched_granularity = SCHED_GRAN_cpu; > + else if (strcmp("core", str) == 0) > + opt_sched_granularity = SCHED_GRAN_core; > + else if (strcmp("socket", str) == 0) > + opt_sched_granularity = SCHED_GRAN_socket; > + else > + return -EINVAL; > + > + return 0; > +} > +custom_param("sched-gran", sched_select_granularity); > +#endif
I'm surprised by the x86 dependency here: I didn't think HT or multi- core are x86-only concepts. Even if Arm may not want this right now, I think it would be better to have a dedicated Kconfig setting, which for now only x86 would select. Also there are several missing blanks here. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel