>>> On 27.05.19 at 18:08, <roger....@citrix.com> wrote: > On Fri, May 24, 2019 at 10:29:26AM +0100, Andrew Cooper wrote: >> On 10/05/2019 17:10, Roger Pau Monne wrote: >> > This avoids code duplication between the helpers. >> > >> > No functional change intended. >> > >> > Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> >> -1. I see this as actively making the code worse, not an improvement. > > Thanks for the feedback. I'm not specially thrilled either way (seeing > Jan provided his RB), the main motivation behind the change was to > avoid having to change the list of parameters to a pci_sbdf_t in each > helper, I find this error prone when the code is the same in all 3 > different helpers except for the size difference. > > Given Andrew's opinion do you still consider this useful Jan?
Well, let me put it that way: I'm fine with the change, but I'm also fine with the code staying as is, seeing Andrew's objection. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
