>>> On 22.05.19 at 12:00, <andrew.coop...@citrix.com> wrote: > On 22/05/2019 10:45, Juergen Gross wrote: >> preempt_count() and the associated per-cpu variable __preempt_count >> are tested in debug build only. So drop them for non-debug builds. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > I'd be tempted to fold patches 2 and 3 together, because they are both > the same change, and it would reduce the churn. > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>, ideally with the > two folded into one.
I'm a little surprised by this: Wasn't it you who generally wanted what ASSERT() expands to (controlled by NDEBUG) be independent of CONFIG_DEBUG, at some point down the road? Aren't you even having ASSERT()s enabled in release builds of XenServer, or am I misremembering? If so patch 3 would move us in the wrong direction. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
