On 15/03/2019 10:47, Jan Beulich wrote:
> @@ -9312,7 +9386,8 @@ x86_emulate(
>  
>          if ( ea.type == OP_MEM )
>          {
> -            rc = ops->write(ea.mem.seg, ea.mem.off, mmvalp, 8 << vex.l, 
> ctxt);
> +            rc = ops->write(ea.mem.seg, truncate_ea(ea.mem.off + first_byte),
> +                            (void *)mmvalp + first_byte, op_bytes, ctxt);
>              if ( rc != X86EMUL_OKAY )
>              {
>                  asm volatile ( "ldmxcsr %0" :: "m" (mxcsr) );

This hunk doesn't appear to fit with the rest of the patch, because it
isn't the first use of first_byte.

Have we been subtly broken before?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to