On 20/05/2019 14:50, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] libxl: fix libxl_domain_need_memory after
> 899433f149d"):
>> After 899433f149d libxl needs to know the content of d_config to
>> determine which QEMU is used. The code is changed such that
>> libxl__domain_set_device_model needs to be called before
>> libxl__domain_build_info_setdefault.
>>
>> This is fine for libxl code, but it is problematic for
>> libxl_domain_need_memory, which is the only public API that takes a
>> build_info. To avoid break its users, provide a compatibility setting
>> inside that function.
>
> This looks plausible to me. I see that this function already makes a
> copy of the b_info, so we do not end up accidentally leaking this new
> default setting to the caller.
>
> Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
>
Thanks.
I have fixed up the issues Roger and Andy found and pushed this patch.
Wei.
> Thanks,
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
