On 4/23/19 9:10 AM, Andrii Anisov wrote: > From: Andrii Anisov <andrii_ani...@epam.com> > > The hypercall employs the same vcpu_register_runstate_memory_area > structure for the interface, but requires registered area to not > cross a page boundary.
This needs a lot more information. I use the following template when writing changelog entries: * What's the current situation * Why is that a problem * How this patch fixes it * Any other information needed to understand the patch. You can drop things when it's obvious, but it's not at all obvious in this case, at least to me. This seems to be implementing a VCPUOP which duplicates another VCPUOP's functionality, with some tweaks. I can back-guess what the differences are from the description (e.g,. the other one must be a virtual address, may cross a page boundary, &c), but I can't tell why that's a problem. Also, I don't see the point of separating the definition from the implementation -- why not squash these two patches together? -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
