>>> On 06.05.19 at 18:11, <andrew.coop...@citrix.com> wrote: > @@ -303,13 +303,18 @@ void __init early_cpu_init(void) > c->x86_capability[cpufeat_word(X86_FEATURE_FPU)] = edx; > c->x86_capability[cpufeat_word(X86_FEATURE_SSE3)] = ecx; > > + c->extended_cpuid_level = cpuid_eax(0x80000000); > + if ((c->extended_cpuid_level >> 16) != 0x8000) > + c->extended_cpuid_level = 0; > + > printk(XENLOG_INFO > "CPU Vendor: %s, Family %u (%#x), Model %u (%#x), Stepping %u > (raw %08x)\n", > x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86, > c->x86_model, c->x86_model, c->x86_mask, eax); > + if (get_model_name(c)) > + printk(XENLOG_INFO "CPU Model: %.48s\n", c->x86_model_id);
Afaics the function doesn't return false when the three leaves are all zero. In this case the line should imo not be logged. Furthermore this extra line is redundant with print_cpu_info() as well as against the idea of the "cpuinfo" command line option (intended to be used to log non-essential details). I'd certainly prefer the extra line to be qualified by an opt_cpu_info check, but I won't insist. In any event I'd like to ask though that the redundancy be addressed. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
