>>> On 03.05.19 at 17:43, <roger....@citrix.com> wrote:
> On Mon, Apr 29, 2019 at 05:23:49AM -0600, Jan Beulich wrote:
>> Don't log a stray trailing comma. Shorten a few fields.
>>
>> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>
> Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Thanks.
>> - for ( i = 0; i < action->nr_guests; i++ )
>> + for ( i = 0; i < action->nr_guests; )
>> {
>> - d = action->guest[i];
>> + d = action->guest[i++];
>
> Per my taste I would leave the increment in the for, but it's just
> taste.
If it was just taste, I'd have left it there, but there is
printk("d%d:%3d(%c%c%c)%c",
d->domain_id, pirq,
evtchn_port_is_pending(d, info->evtchn) ? 'P' : '-',
evtchn_port_is_masked(d, info->evtchn) ? 'M' : '-',
info->masked ? 'M' : '-',
i < action->nr_guests ? ',' : '\n');
which depends on the early increment (or else would need adding
" + 1" or " - 1" on one side of the < . In fact this change is the
"don't log a stray trailing comma" part.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
