>>> On 30.04.19 at 23:02, <sstabell...@kernel.org> wrote: > Now that map_mmio_regions takes a p2mt parameter, there is no need to > keep "mmio" in the name. The p2mt parameter does a better job at > expressing what the mapping is about. Let's save the environment 5 > characters at a time.
But as per the cover letter the purpose is to allow mapping iomem (which I take is just an alternative term for MMIO). Even if that's misleading, {,un}map_regions() is a little too unspecific for my taste. At which point at least the environment saving argument goes away ;-) As to the series as a whole, I guess you first want to come to an agreement with Julien. Only then it'll make sense to actually review the changes, I think. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel