>>> On 26.04.19 at 19:21, <ta...@tklengyel.com> wrote: > @@ -999,6 +996,10 @@ static int share_pages(struct domain *sd, gfn_t sgfn, > shr_handle_t sh, > mem_sharing_page_unlock(secondpg); > mem_sharing_page_unlock(firstpg); > > + BUG_ON(!put_count); > + while ( put_count-- ) > + put_page_and_type(cpage); > + > /* Free the client page */ > if(test_and_clear_bit(_PGC_allocated, &cpage->count_info)) > put_page(cpage);
If this was to happen before all the put_page_and_type() calls, wouldn't it render unnecessary the extra get_page()/put_page() around this code region? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel