On 4/23/19 11:37 AM, Andrew Cooper wrote:
> On 22/04/2019 13:39, Dongli Zhang wrote:
>> Print log at level XENLOG_ERR (instead XENLOG_INFO) as domain_crash()
>> indicates there is fatal error.
>>
>> Signed-off-by: Dongli Zhang <dongli.zh...@oracle.com>
>> ---
>> xen/common/grant_table.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
>> index 80728ea..725c618 100644
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -1282,7 +1282,7 @@ unmap_common(
>> if ( unlikely((rd = rcu_lock_domain_by_id(dom)) == NULL) )
>> {
>> /* This can happen when a grant is implicitly unmapped. */
>> - gdprintk(XENLOG_INFO, "Could not find domain %d\n", dom);
>> + gdprintk(XENLOG_ERR, "Could not find domain %d\n", dom);
>
> While I agree with the change in principle, what does this actually do?
> The entire printk() is compiled out in release builds, and debug builds
> log all messages.
...by default; but presumably you can turn that down, right?
This also changes the prefix in the log output, right? That would make
it easier to identify which message is important for undertanding why
your domain just crashed.
Acked-by: George Dunlap <george.dun...@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
