On 4/18/19 9:11 AM, George Dunlap wrote: > On 4/18/19 2:52 AM, Daniel P. Smith wrote: >> This deals with two casting issues for compiling under go 1.11: >> - explicitly cast to *C.xentoollog_logger for Ctx.logger pointer >> - add cast to unsafe.Pointer for the C string cpath >> >> Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com> > > Reviewed-by: George Dunlap <george.dun...@citrix.com> > > BTW, do you know if this will compile for older versions of go?
Per the suggestion on IRC, I did a test compile with golang 1.10.8 as the version available with Ubuntu 18.04 was 1.10.1. Since this matters, the environment was setup with Xen 4.12 tools. If there are additional variations you would like to see, please let me know as I am using a docker container setup for reproducible build environments and should be able to spin up different variations fairly easily. > This should be considered for backport as well (cc'ing Jan). > Ack and thank you. V/r, Daniel P. Smith _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
