Hi,

On 4/12/19 12:16 PM, Jan Beulich wrote:
On 11.04.19 at 15:25, <andrew.coop...@citrix.com> wrote:
The use of return_reg() assumes ARM's 32bit ABI.  Therefore, a failure such as
-EINVAL will appear as a large positive number near 4 billion to a 64bit ARM
guest which happens to use continue_hypercall_on_cpu().

Introduce a new arch_hypercall_tasklet_result() hook which is implemented by
both architectures, and drop the return_reg() macros.  This logic will be
extended in a later change to make continuations out of the tasklet work.

Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>

On the assumption that simply fixing Arm's return_reg() would
not suffice with your further plans

I would definitely prefer to keep a static inline function unless there are plan to make arch_hypercall_tasklet_result more complex.

Andrew, could you enlighten us on your plans?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to