>>> On 08.04.19 at 13:58, <julien.gr...@arm.com> wrote: > On 3/5/19 1:28 PM, Jan Beulich wrote: >> @@ -298,7 +298,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_add_to_physm >> >> /* >> * Unmaps the page appearing at a particular GPFN from the specified >> guest's >> - * pseudophysical address space. >> + * physical address space (translated guests only). > > While you modify the comment, can you replace GPFN with GFN?
I did consider this when writing the patch, but then this would bring it out of sync with the structure field and its associated comment. Plus the "add" side comment would then want changing too. And public/memory.h has quite a few more uses of GPFN / gpfn. To be honest I'd prefer to leave this as is right here, for it to get cleaned up in one go. > Other than that: > > Reviewed-by: Julien Grall <julien.gr...@arm.com> Thanks, but as per above I'm not sure whether to actually apply it. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
