On 3/13/19 12:38 PM, Jan Beulich wrote: > In a few cases only a query is intended, i.e. without populating a > possible PoD or paged out entry, when the intention is to replace the > current entry anyway. Use get_gfn_query() there instead. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
The first one should be fine, but pretty sure the second two will mis-fire for PoD: p2m->pod.entry_count won't get updated. As it is, it's sort-of misfiring already, since the "freed" memory won't be reclaimed for the PoD cache. Which probably means it's time for some serious refactoring to prevent this sort of error from creeping in. p2m->pod.entry_count accounting should probably be moved into p2m_entry_modify(), and p2m_pod_decrease_reservation() should probably be moved somewhere else -- perhaps guest_remove_page() or something? At any rate, a we probably need to review of the layers and what everyone needs from them, and do things at the right level. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
