On 02/04/2019 13:57, Jan Beulich wrote: >>>> On 02.04.19 at 07:34, <jgr...@suse.com> wrote: >> Instead of freeing percpu areas during suspend and allocating them >> again when resuming keep them. Only free an area in case a cpu didn't >> come up again when resuming. >> >> It should be noted that there is a potential change in behaviour as >> the percpu areas are no longer zeroed out during suspend/resume. While >> I have checked the called cpu notifier hooks to cope with that there >> might be some well hidden dependency on the previous behaviour. OTOH >> a component not registering itself for cpu down/up and expecting to >> see a zeroed percpu variable after suspend/resume is kind of broken >> already. And the opposite case, where a component is not registered >> to be called for cpu down/up and is not expecting a percpu variable >> suddenly to be zero due to suspend/resume is much more probable, >> especially as the suspend/resume functionality seems not to be tested >> that often. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> >> Reviewed-by: Dario Faggioli <dfaggi...@suse.com> > > Acked-by: Jan Beulich <jbeul...@suse.com> > > Wasn't there a request though to do the same on Arm? Even if > right now Arm doesn't support suspend/resume out of the box, > I think it would be better if such relatively generic adjustments > were done in lock step.
Julien asked to include that in the ARM suspend/resume series. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
