On 01/04/2019 10:10, Jan Beulich wrote: >>>> On 30.03.19 at 11:22, <jgr...@suse.com> wrote: >> On 29/03/2019 20:36, Andrew Cooper wrote: >>> In practice, all this flag does is permit the use of VCPUOP_get_physid, >>> disallow the use of vcpu_set_hard_affinity(), and allow dom0 to attempt >>> to actually write to MSR_AMD64_NB_CFG, MSR_FAM10H_MMIO_CONF_BASE, >>> MSR_IA32_UCODE_REV, MSR_IA32_THERM_CONTROL and >>> MSR_IA32_ENERGY_PERF_BIAS, rather than having the write silently discarded. >>> >>> Dom0's use of those MSRs is dubious at best, and disabled by default, >>> *and* when active, also cross-checks with the hard affinity mask. Does >>> anyone use dom0_vcpus_pin in production? >> >> I have seen it on customer systems. > > Same here, but I've never seen it used for a good reason. > >>> I think there is quite a lot of value in getting rid of d->is_pinned and >>> is_pinned_vcpu() entirely, with will remove an extreme >>> corner-case-x86-ism out of the common code. > > I think its origin was "cpufreq=dom0-kernel", which I think should go > away with it then.
Fine with me. Another candidate for a later cleanup, I guess. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel