On 3/26/19 1:39 PM, Jan Beulich wrote: >> This is a regression in 4.12 and needs resolving. The choice is between >> reverting dcf41790 or removing this code, and reverting dcf41790 is >> obviously not a valid thing to do. > > As explained before, there was an earlier regression, which - if it > had been noticed in time - would have made all versions from 4.2 > to 4.11 behave like 4.12 without your change. This behavior was > intended by the original author. Ripping the code out by convincing > people to bypass normal review flow is, well, not very nice to put it > mildly.
I would like to say, I thought Andy tried to be very scrupulous here. He had two different R-b's from people familiar with the code, and an Ack from the release coordinator. I think he would have been justified in checking the patch in on that basis, but just to make sure he was doing the right thing, he asked someone else from "The Rest" (me) to double-check to make sure. Given the difference between how the two of you approach this sort of thing, I understand why you might interpret that in a negative light. But I don't think it's in the best interest of the project for people to be completely risk-averse in this sort of situation. We have source control for a reason: If the change turns out to have been wrong, we can revert it. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
