>>> On 27.03.19 at 19:45, <julien.gr...@arm.com> wrote: > Clang uses "-target" option for cross-compilation.
And all possible targets are always available? I'd like to point out that CROSS_COMPILE can be used for other than actual cross compilation, e.g. building with just an alternative tool chain built for the same target. Dropping the $(CROSS_COMPILE) prefixes makes this impossible afaict. Requiring suitable wrapper scripts to be put in place would seem better to me. I also wonder why this change is needed for Arm, but wasn't needed so far for x86. But perhaps no-one ever tried using it so far ... > --- a/config/StdGNU.mk > +++ b/config/StdGNU.mk > @@ -1,8 +1,13 @@ > AS = $(CROSS_COMPILE)as > LD = $(CROSS_COMPILE)ld > ifeq ($(clang),y) > -CC = $(CROSS_COMPILE)clang > -CXX = $(CROSS_COMPILE)clang++ > +ifneq ($(CROSS_COMPILE),) > +CC = clang -target $(CROSS_COMPILE:-=) > +CXX = clang++ -target $(CROSS_COMPILE:-=) Is dropping dashes from the variable uniformly correct? If so, could you please clarify in the commit message why that is? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
