On Fri, Mar 15, 2019 at 01:39:05PM +0000, Andrew Cooper wrote: > There isn't a plausible reason to insert nops like this into code. > > The sole use is in do_debug_key(), and exists to prevent the compiler > optimising the tail of the function with 'jmp debugger_trap_fatal' > > In practice, a compiler barrier suffices just as well to prevent the tailcall, > and doesn't involve inserting unnecessary instructions. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Wei Liu <wei.l...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
