Hi Jan,
On 13/03/2019 14:45, Jan Beulich wrote:
On 18.02.19 at 12:35, <julien.gr...@arm.com> wrote:
mfn_to_gfn and mfn_to_gmfn are doing exactly the same except the former
is using mfn_t.
Furthermore, the naming of the former is more consistent with the
current naming scheme (GFN/MFN). So use replace mfn_to_gmfn with
mfn_to_gfn in x86 code.
No functional changes.
Signed-off-by: Julien Grall <julien.gr...@arm.com>
Fundamentally I'm fine with this change, but before making its use
more wide-spread, wouldn't it be better to make mfn_to_gfn()
fully type-safe, i.e. have it also return gfn_t? There aren't that
many uses of the function just yet, and doing the conversion now
would save us from having to touch all places you now change
yet another time.
I vaguely recall some problems when trying to use typesafe GFN. Maybe it is
because I was trying to cleanup the code at the same time.
Let me have another try.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
