On 06/03/2019 13:22, Laszlo Ersek wrote: > On 03/06/19 13:40, Igor Druzhinin wrote: >> On Xen, hvmloader firmware leaves address decoding enabled for >> enumerated PCI device before jumping into OVMF. OVMF seems to >> expect it to be disabled and tries to size PCI BARs in several places >> without disabling it which causes BAR64, for example, being >> incorrectly placed by QEMU. >> >> Fix it by disabling PCI address decoding explicitly before the >> first attempt to size BARs on Xen. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Igor Druzhinin <igor.druzhi...@citrix.com> >> --- >> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 34 >> +++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >> b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >> index 408fb24..9940335 100644 >> --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >> +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >> @@ -55,6 +55,33 @@ PcatPciRootBridgeBarExisted ( >> EnableInterrupts (); >> } >> >> +#define EFI_PCI_COMMAND_DECODE ((UINT16)(EFI_PCI_COMMAND_IO_SPACE | \ >> + EFI_PCI_COMMAND_MEMORY_SPACE)) > > I thought I asked you not to define a macro here that started with the > "EFI_" prefix :/ > > http://mid.mail-archive.com/dd8e3c9e-cb76-d3fe-6a10-c0a41c714b56@redhat.com >
This is a resend of v1 patch series to get Xen folks into CC and gather comments. I expect v2. Igor _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
