>>> On 05.03.19 at 23:38, <sstabell...@kernel.org> wrote: > Use __UINTPTR_TYPE__ to define uintptr_t. A later patch will make use of > __PTRDIFF_TYPE__ to define ptrdiff_t. > > Signed-off-by: Stefano Stabellini <stefa...@xilinx.com> > Reviewed-by: Ian Jackson <ian.jack...@eu.citrix.com>
As before - I object to this change without the description supplying both a reason (which would better also explain why the current way of defining uintptr_t is detrimental) and a discussion why it is okay for us to use __UINTPTR_TYPE__, despite (at least) gcc making this available only under certain conditions (i.e. it would need to be confirmed that whatever the conditions they're always met for us). With this I think it is pretty clear that you would better have split the original patch the other way around - the uncontroversial one first, as that one now wouldn't apply without the one here. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel