On 2/25/19 16:59, Jan Beulich wrote: >>>> On 25.02.19 at 14:34, <nmant...@amazon.de> wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -4109,6 +4109,11 @@ static int hvmop_set_param( >> if ( a.index >= HVM_NR_PARAMS ) >> return -EINVAL; >> >> + /* >> + * Make sure the above bound check is not bypassed during speculation. >> + */ >> + block_speculation(); >> + >> d = rcu_lock_domain_by_any_id(a.domid); >> if ( d == NULL ) >> return -ESRCH; >> @@ -4375,6 +4380,11 @@ static int hvmop_get_param( >> if ( a.index >= HVM_NR_PARAMS ) >> return -EINVAL; >> >> + /* >> + * Make sure the above bound check is not bypassed during speculation. >> + */ >> + block_speculation(); > Comment style (single line) in both cases. This could be done while > committing, and with it taken care of > Acked-by: Jan Beulich <jbeul...@suse.com>
I'll turn the comments into single line comments. Best, Norbert Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich Ust-ID: DE 289 237 879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
