On Tue, Feb 19, 2019 at 05:47:34AM +0000, Tian, Kevin wrote: > > From: Roger Pau Monne [mailto:roger....@citrix.com] > > Sent: Tuesday, February 19, 2019 1:27 AM > > > > So that it can be shared by both ept, npt and shadow code, instead of > > duplicating it. > > > > No change in functionality intended. > > > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > > Reviewed-by: George Dunlap <george.dun...@citrix.com> > > Reviewed-by: Kevin Tian <kevin.t...@intel.com>. with one > small comment: > > > +static inline void p2m_entry_modify(struct p2m_domain *p2m, > > p2m_type_t nt, > > + p2m_type_t ot, unsigned int level) > > +{ > > + if ( level != 1 || nt == ot ) > > + return; > > based on type check, does it make more sense to call it > p2m_entry_modify_type?
Later on the function will be expanded to also take a new/old mfn pair of parameters, so I think the name is fine taking into account the expansion of the function later in the patch series. Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
