At 04:41 -0700 on 07 Feb (1549514492), Jan Beulich wrote: > A previously bad situation has become worse with the early setting of > ->max_vcpus: The value returned by shadow_min_acceptable_pages() has > further grown, and hence now holds back even more memory from use for > the p2m. > > Make sh_min_allocation() account for all p2m memory needed for > shadow_enable() to succeed during domain creation (at which point the > domain has no memory at all allocated to it yet, and hence use of > d->tot_pages is meaningless). > > Also make shadow_min_acceptable_pages() no longer needlessly add 1 to > the vCPU count. > > Finally make the debugging printk() in shadow_alloc_p2m_page() a little > more useful by logging some of the relevant domain settings. > > Reported-by: Roger Pau Monné <roger....@citrix.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Acked-by: Tim Deegan <t...@xen.org> I don't think it's worth bikeshedding too hard over individual pages on this path; these numbers look OK. Cheers, Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
