On Fri, 25 Jan 2019 19:06:02 +0200
Andrii Anisov <andrii.ani...@gmail.com> wrote:
> From: Andrii Anisov <andrii_ani...@epam.com>
>
> Currently, that assert condition does not correspond to a comment
> above and makes assertion failed on HW IRQ disconnection.
> Fix the condition so it corresponds to the comment and allows IRQ
> disconnection on debug builds.
>
> Fixes: ec2a2f1 ("ARM: VGIC: factor out vgic_connect_hw_irq()")
> Signed-off-by: Andrii Anisov <andrii_ani...@epam.com>
> Suggested-by: Stefan Nuernberger <s...@amazon.de>
Reviewed-by: Andre Przywara <andre.przyw...@arm.com>
Cheers,
Andre.
> ---
> in v2:
> - updated condition as suggested by Stefan
> - provided detailed commit message
> - added Suggested-by from Stefan
> - referred a commit introduced the issue
>
> xen/arch/arm/gic-vgic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
> index 48922f5..a3bba85 100644
> --- a/xen/arch/arm/gic-vgic.c
> +++ b/xen/arch/arm/gic-vgic.c
> @@ -443,7 +443,7 @@ int vgic_connect_hw_irq(struct domain *d, struct
> vcpu *v, unsigned int virq, int ret = 0;
>
> /* "desc" is optional when we disconnect an IRQ. */
> - ASSERT(connect && desc);
> + ASSERT(!connect || desc);
>
> /* We are taking to rank lock to prevent parallel connections. */
> vgic_lock_rank(v_target, rank, flags);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
