> -----Original Message----- > From: Andrii Anisov [mailto:andrii.ani...@gmail.com] > Sent: 23 January 2019 12:40 > To: Paul Durrant <paul.durr...@citrix.com>; 'Julien Grall' > <julien.gr...@arm.com>; xen-devel@lists.xenproject.org > Cc: Stefano Stabellini <sstabell...@kernel.org>; Andrii Anisov > <andrii_ani...@epam.com> > Subject: Re: [RFC] arm/p2m: call iommu iotlb flush if iommu exists and > enabled > > Hello Paul, > > On 23.01.19 13:45, Paul Durrant wrote: > > Yes, this was a mistake when moving from the old macros and need_iommu. > Andrii is correct that need_iommu_pt_sync() is supposed to gate whether an > explicit map/unmap is needed. The need for flush should only depend on > has_iommu_pt(). > So I fix the commit message and send V2 for XEN 4.12.
Cool. > > > There is also iommu_use_hap_pt() which is actually defined as > has_iommu_pt(), but I wonder whether that should just go away for ARM > since the page tables are always shared. > Actually, the mainline currently supports only SMMU, which does share the > page table. > But it is not always true, we are using HW, where PT is not shared. And > going to upstream that support one day. Oh, ok. Leave it in then :-) Paul > > -- > Sincerely, > Andrii Anisov. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel