On 23/01/2019 11:42, Jan Beulich wrote:
>
>> --- a/xen/arch/x86/guest/pvh-boot.c
>> +++ b/xen/arch/x86/guest/pvh-boot.c
>> @@ -123,28 +123,29 @@ void __init pvh_print_info(void)
>> const struct hvm_modlist_entry *entry;
>> unsigned int i;
>>
>> - ASSERT(pvh_info->magic == XEN_HVM_START_MAGIC_VALUE);
>> -
>> - printk("PVH start info: (pa %08x)\n", pvh_start_info_pa);
>> - printk(" version: %u\n", pvh_info->version);
>> - printk(" flags: %#"PRIx32"\n", pvh_info->flags);
>> - printk(" nr_modules: %u\n", pvh_info->nr_modules);
>> - printk(" modlist_pa: %016"PRIx64"\n", pvh_info->modlist_paddr);
>> - printk(" cmdline_pa: %016"PRIx64"\n", pvh_info->cmdline_paddr);
>> + printk("PVH start info: (pa 0x%08x)\n", pvh_start_info_pa);
>> + printk(" version %u, flags %#x\n", pvh_info->version, pvh_info->flags);
>> +
>> + printk(" cmdline 0x%08"PRIx64, pvh_info->cmdline_paddr);
>> if ( pvh_info->cmdline_paddr )
>> - printk(" cmdline: '%s'\n", (char
>> *)__va(pvh_info->cmdline_paddr));
>> - printk(" rsdp_pa: %016"PRIx64"\n", pvh_info->rsdp_paddr);
>> + printk(" '%s'", (char *)__va(pvh_info->cmdline_paddr));
> Is the cast here really necessary?
Yes. Omitting it causes -Wformat to object to passing void* into
something expecting char*.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
