On Mon, Jan 21, 2019 at 01:59:40AM -0800, Christopher Clark wrote: > Version five of this patch series: > > * Changes are primarily addressing feedback from the v4 series reviews. > Many points noted on the invididual commit posts. > > * Critical sections have been shrunk, with allocations and frees > pulled outside where possible, reordering logic within hypercall ops. > > * A new ring hash function implemented, derived from the djb2 string > hash function. > > * Flags returned by the notify op have been simplified. > > * Now uses a single argo boot parameter, taking a list: > - top level boolean to enable/disable Argo > - mac-permissive option to enable/disable wildcard rings > - command line doc edit: no "CONFIG_ARGO" but refers to build config > > * Switched to use the standard list data structures used by Xen's > common code.
AFAIK this was not requested by any reviewer, so I wonder why you made such change. The more that you open coded some of the list_ macros instead of just doing a s/hlist_/list_/ replacement. I'm fine with using list instead of hlist, but I don't understand why you decided to open code list_for_each and list_for_each_safe instead of using the macros provided by Xen. Is there an issue with such macros? I've made a couple of minor comments, but I think the current status is good, and fixing those minor comments is going to be trivial. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
