On 11/01/2019 03:14, Stefano Stabellini wrote: > Hi Juergen, Jan, > > I spoke with Julien: we are both convinced that the unsigned long > solution is best. But Julien also did some research and he thinks that > Jan's version (returning pointer type) not only does not help with > MISRA-C, but also doesn't solve the potential GCC problem either. A > description of the GCC issue is available here: > > https://kristerw.blogspot.com/2016/12/pointer-comparison-invalid-optimization.html?m=1 > > (Also keep in mind that Linux uses the unsigned long solution to solve > the GCC issue, deviating from it doesn't seem wise.) > > I would like to ask for a freeze exception until Monday/Tuesday next > week when Julien will be back, and he and his team will be able to > provide more evidence that the unsigned long solution is correct, while > the other solution is not correct.
I'm fine with the freeze exception in this case. Reasoning: The functional correctness of the patches is rather easy to verify. The main risks are: - syntactical/semantical correctness - handled by the compiler - MISRA-C correctness - shouldn't be worse than without the patches So the risk for the release seems to be rather low. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
