>>> On 09.01.19 at 15:26, <jandr...@gmail.com> wrote: > On Wed, Jan 9, 2019 at 4:35 AM Jan Beulich <jbeul...@suse.com> wrote: >> >>> On 08.01.19 at 23:54, <jandr...@gmail.com> wrote: >> > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark >> > <christopher.w.cl...@gmail.com> wrote: >> >> + */ >> >> + struct argo_ring_info *ring_info; >> >> + /* domain to be notified when space is available */ >> >> + domid_t domain_id; >> >> + uint16_t pad; >> > >> > Can we order domain_id after len and drop the pad? >> >> That would still call for a pad field - we prefer to have explicit padding, >> and also to check it's zero, the latter to allow for assigning meaning to >> the field down the road. > > This struct is internal to Xen and argo, so do we still need explicit > padding?
Oh, internal structures don't need any explicit padding. Where the domain_id field gets placed still doesn't matter then, though. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
