On 1/7/19 8:30 PM, Eduardo Habkost wrote:
> stringify() is useful when we need to use macros in compat_props
> (like when we set virtio-baloon-pci.class=PCI_CLASS_MEMORY_RAM at
> pc_i440fx_1_0_machine_options()), but it is pointless when we are
> already providing a number literal.
>
> Replace stringify() with string literals when appropriate.
>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
> ---
> hw/core/machine.c | 8 ++--
> hw/i386/pc.c | 94 +++++++++++++++++++++++------------------------
> hw/i386/pc_piix.c | 30 +++++++--------
> hw/ppc/spapr.c | 2 +-
> 4 files changed, 67 insertions(+), 67 deletions(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index f8563efb86..4b4d6c23de 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -135,11 +135,11 @@ GlobalProperty hw_compat_2_8[] = {
> {
> .driver = "fw_cfg_mem",
> .property = "x-file-slots",
> - .value = stringify(0x10),
> + .value = "0x10",
[...]
Lovely.
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
