On 20/12/2018 19:23, Julien Grall wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 2b5e43f50a..cd34149d13 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -406,6 +406,38 @@ mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t
> *t)
> return mfn;
> }
>
> +struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn,
> + p2m_type_t *t)
> +{
> + struct page_info *page;
> + p2m_type_t p2mt;
> + mfn_t mfn = p2m_lookup(d, gfn, &p2mt);
> +
> + if (t)
Spaces
> + *t = p2mt;
> +
> + if ( !p2m_is_any_ram(p2mt) )
> + return NULL;
> +
> + if ( !mfn_valid(mfn) )
> + return NULL;
Newline
> + page = mfn_to_page(mfn);
> +
> + /*
> + * get_page won't work on foreign mapping because the page doesn't
> + * belong to the current domain.
> + */
> + if ( p2m_is_foreign(p2mt) )
> + {
> + struct domain *fdom = page_get_owner_and_reference(page);
> + ASSERT(fdom != NULL);
> + ASSERT(fdom != d);
> + return page;
> + }
> +
> + return (get_page(page, d) ? page: NULL);
No need for the outer brackets.
All trivial style issues, so can be fixed on commit.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
