Hi Stefano,

On 12/17/18 10:10 PM, Stefano Stabellini wrote:
+    /* These calls are safe and always allowed.  */
+    case EEMI_FID(ZYNQMP_SIP_SVC_CALL_COUNT):
+    case EEMI_FID(ZYNQMP_SIP_SVC_UID):
+    case EEMI_FID(ZYNQMP_SIP_SVC_VERSION):

I am a bit surprised that you implement those one using SMC64. Why would you duplicate the SMC32 version (ARM_SMCCC_CALL_COUNT_FID(SIP))?

I also don't seem to find them neither in the spec nor in the ATF code.

The rest of the code looks good to me.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to